New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ichimoku Cloud #1263

Merged
merged 2 commits into from Jul 13, 2016

Conversation

Projects
None yet
4 participants
@llllllllll
Member

llllllllll commented Jun 5, 2016

The more interesting feature here is providing default arguments for params.

@llllllllll llllllllll force-pushed the cloud-computing branch 3 times, most recently from 1cb1e63 to 5d48f57 Jun 5, 2016

@coveralls

This comment has been minimized.

coveralls commented Jun 6, 2016

Coverage Status

Coverage increased (+0.04%) to 82.77% when pulling 5d48f57 on cloud-computing into af38b02 on master.

@llllllllll llllllllll force-pushed the cloud-computing branch from 5d48f57 to fbbb6ed Jun 6, 2016

@coveralls

This comment has been minimized.

coveralls commented Jun 6, 2016

Coverage Status

Coverage increased (+0.07%) to 82.782% when pulling fbbb6ed on cloud-computing into 6979ae8 on master.

@ssanderson

This comment has been minimized.

Member

ssanderson commented Jul 12, 2016

@llllllllll I don't really know how to judge the Ichimoku stuff here, but 👍 on the default params API/impl.

@llllllllll llllllllll force-pushed the cloud-computing branch from fbbb6ed to 0f1c080 Jul 12, 2016

@coveralls

This comment has been minimized.

coveralls commented Jul 12, 2016

Coverage Status

Coverage increased (+0.03%) to 83.03% when pulling 0f1c080 on cloud-computing into db4e060 on master.

@llllllllll llllllllll merged commit 4a0629b into master Jul 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the cloud-computing branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment