New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add NotNullFilter. #1345

Merged
merged 1 commit into from Jul 25, 2016

Conversation

Projects
None yet
4 participants
@ssanderson
Member

ssanderson commented Jul 22, 2016

No description provided.

@mtydykov mtydykov force-pushed the notnull-filter branch from 3aa2558 to 43957b0 Jul 22, 2016

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jul 22, 2016

What is wrong with ~self.isnull()?

@ssanderson

This comment has been minimized.

Member

ssanderson commented Jul 22, 2016

What is wrong with ~self.isnull()?

Downstream @mtydykov wanted to write a Filter that was NotNullFilter with default inputs, and implementing it here and using it for notnull saves an intermediate array in the term graph.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jul 22, 2016

Okay. Do we have the ability to do a graph rewrite rule for ~IsNull -> NotNull?

@ssanderson

This comment has been minimized.

Member

ssanderson commented Jul 22, 2016

Okay. Do we have the ability to do a graph rewrite rule for ~IsNull -> NotNull?

We're not doing any graph rewriting right now.

@coveralls

This comment has been minimized.

coveralls commented Jul 22, 2016

Coverage Status

Coverage increased (+0.004%) to 83.555% when pulling 43957b0 on notnull-filter into 5fd6550 on master.

@ssanderson ssanderson merged commit a424225 into master Jul 25, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssanderson ssanderson deleted the notnull-filter branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment