New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point in time assets db again #1361

Merged
merged 4 commits into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@llllllllll
Member

llllllllll commented Aug 1, 2016

We are doing it this time!

There are 2 commits after the revert that should be reviewed now.

def __eq__(self, other):
return reduce(
getattr(self, attr) == getattr(other, attr)
for attr in self.__slots__

This comment has been minimized.

@richafrank

richafrank Aug 1, 2016

Member

Is this reduction correct?

This comment has been minimized.

@llllllllll

llllllllll Aug 1, 2016

Member

nope, I will add a test for this.

@llllllllll llllllllll force-pushed the point-in-time-assets-db-again branch from f3f95a8 to 8499e86 Aug 2, 2016

@llllllllll llllllllll force-pushed the point-in-time-assets-db-again branch from 8499e86 to 19ecb8d Aug 2, 2016

@coveralls

This comment has been minimized.

coveralls commented Aug 2, 2016

Coverage Status

Coverage decreased (-0.2%) to 85.363% when pulling 19ecb8d on point-in-time-assets-db-again into 5b9d2e2 on master.

@llllllllll llllllllll merged commit 74c4673 into master Aug 2, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the point-in-time-assets-db-again branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment