Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest versions #1430

Merged
merged 6 commits into from Aug 24, 2016
Merged

Ingest versions #1430

merged 6 commits into from Aug 24, 2016

Conversation

@richafrank
Copy link
Member

@richafrank richafrank commented Aug 23, 2016

zipline ingest can downgrade the assets db

This lets us publish an "old" db version for the most recent release of zipline, using the latest code base.

def bundle_ingest_no_create_writers(*args, **kwargs):
called[0] = True

with self.assertRaises(ValueError):

This comment has been minimized.

@llllllllll

llllllllll Aug 23, 2016
Contributor

wgy does the first ingest fail? Can we use assert_raises_regex to make this more clear?

This comment has been minimized.

@richafrank

richafrank Aug 24, 2016
Author Member

Will add.

self._tmpfile.close()
move(self._name, self._final_path)

def __getattr__(self, attr):

This comment has been minimized.

@llllllllll

llllllllll Aug 23, 2016
Contributor

why did we remove the __getattr__?

This comment has been minimized.

@richafrank

richafrank Aug 24, 2016
Author Member

It was unused, so I removed it. This class itself was actually unused and had acquired some bitrot.

SQLITE_MAX_VARIABLE_NUMBER = 998


def group_into_chunks(items, chunk_size=SQLITE_MAX_VARIABLE_NUMBER):
items = list(items)
return [items[x:x+chunk_size]
for x in range(0, len(items), chunk_size)]


coerce_string_to_conn = coerce_string(sqlite3.connect)

This comment has been minimized.

@llllllllll

llllllllll Aug 23, 2016
Contributor

This is awesome, thanks!

@coveralls
Copy link

@coveralls coveralls commented Aug 23, 2016

Coverage Status

Coverage increased (+0.3%) to 86.462% when pulling ba14bf0 on ingest-versions into 82436aa on master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Aug 23, 2016

Coverage Status

Coverage increased (+0.3%) to 86.462% when pulling ba14bf0 on ingest-versions into 82436aa on master.

@richafrank richafrank force-pushed the ingest-versions branch from ba14bf0 to 4bcb5f8 Aug 24, 2016
@coveralls
Copy link

@coveralls coveralls commented Aug 24, 2016

Coverage Status

Coverage increased (+0.1%) to 86.34% when pulling 4bcb5f8 on ingest-versions into eba78ae on master.

@richafrank richafrank force-pushed the ingest-versions branch from 4bcb5f8 to f4ad4c2 Aug 24, 2016
@coveralls
Copy link

@coveralls coveralls commented Aug 24, 2016

Coverage Status

Coverage increased (+0.1%) to 86.29% when pulling f4ad4c2 on ingest-versions into a788191 on master.

richafrank added 3 commits Aug 23, 2016
This lets us publish an "old" db version for the most recent release
of zipline, using the latest code base.
@richafrank richafrank force-pushed the ingest-versions branch from f4ad4c2 to 317c5f0 Aug 24, 2016
@coveralls
Copy link

@coveralls coveralls commented Aug 24, 2016

Coverage Status

Coverage increased (+0.1%) to 86.29% when pulling 317c5f0 on ingest-versions into a788191 on master.

@richafrank richafrank merged commit 3a7438c into master Aug 24, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richafrank richafrank deleted the ingest-versions branch Aug 24, 2016
bartosh pushed a commit to bartosh/zipline that referenced this pull request Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.