Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add asset dispatch to data portal. #1435

Merged
merged 1 commit into from Aug 26, 2016

Conversation

@ehebert
Copy link
Contributor

@ehebert ehebert commented Aug 26, 2016

Combine the equity and future readers into asset dispatch readers, so
that simulations that use both asset types can access data for each.

This patch enables history for future assets in algorithms; however,
it does not add extra coverage in the test_data_portal or test_history
to cover future assets. Those tests will follow, however putting this in
separately since it shows that the wrapping of the readers in the asset
dispatch reader does not break existing equity strategies.

Combine the equity and future readers into asset dispatch readers, so
that simulations that use both asset types can access data for each.

This patch enables `history` for future assets in algorithms; however,
it does not add extra coverage in the `test_data_portal` or `test_history`
to cover future assets. Those tests will follow, however putting this in
separately since it shows that the wrapping of the readers in the asset
dispatch reader does not break existing equity strategies.
@coveralls
Copy link

@coveralls coveralls commented Aug 26, 2016

Coverage Status

Coverage increased (+0.08%) to 86.394% when pulling 40c7deb on use-dispatch-reader-in-data-portal into c460af0 on master.

2 similar comments
@coveralls
Copy link

@coveralls coveralls commented Aug 26, 2016

Coverage Status

Coverage increased (+0.08%) to 86.394% when pulling 40c7deb on use-dispatch-reader-in-data-portal into c460af0 on master.

@coveralls
Copy link

@coveralls coveralls commented Aug 26, 2016

Coverage Status

Coverage increased (+0.08%) to 86.394% when pulling 40c7deb on use-dispatch-reader-in-data-portal into c460af0 on master.

@ehebert ehebert merged commit 4a5d6e4 into master Aug 26, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ehebert ehebert deleted the use-dispatch-reader-in-data-portal branch Aug 26, 2016
bartosh pushed a commit to bartosh/zipline that referenced this pull request Sep 27, 2016
…r-in-data-portal

ENH: Add asset dispatch to data portal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.