Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: run_algorithm with no data source should default #1479

Merged
merged 1 commit into from Sep 12, 2016

Conversation

@richafrank
Copy link
Member

@richafrank richafrank commented Sep 11, 2016

to 'quantopian-quandl' bundle

For #1374

I considered adding a unit test. Because of its dependence on the global load of a bundle, it would depend on ingesting the real quantopian-quandl bundle first, or we'd need to register a replacement bundle globally for the span of the test. So I haven't included a unit test here.

@coveralls
Copy link

@coveralls coveralls commented Sep 11, 2016

Coverage Status

Coverage decreased (-0.006%) to 86.652% when pulling 91d7ded on run_algo-defaults into df07f67 on master.

@llllllllll
Copy link
Contributor

@llllllllll llllllllll commented Sep 12, 2016

lgtm, do you think there is an easy test for this?

@richafrank
Copy link
Member Author

@richafrank richafrank commented Sep 12, 2016

Not easy, at least. 😄

to 'quantopian-quandl' bundle
@richafrank richafrank force-pushed the run_algo-defaults branch from 91d7ded to 3bdba2e Sep 12, 2016
@coveralls
Copy link

@coveralls coveralls commented Sep 12, 2016

Coverage Status

Coverage remained the same at 86.659% when pulling 3bdba2e on run_algo-defaults into df07f67 on master.

@richafrank richafrank merged commit 7b2ca76 into master Sep 12, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richafrank richafrank deleted the run_algo-defaults branch Sep 12, 2016
bartosh pushed a commit to bartosh/zipline that referenced this pull request Sep 27, 2016
BUG: run_algorithm with no data source should default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.