New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add additional fields to __getitem__ for Order #1483

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
3 participants
@jdricklefs
Member

jdricklefs commented Sep 13, 2016

CC: @llllllllll

These were previously available like the other deprecated attributes here. Not sure where the discrepancy from the list you had here vs. the list in the API docs came from - might be something else we need to update?

MAINT: Add additional fields to __getitem__ for Order
These were previously available like the others.
@coveralls

This comment has been minimized.

coveralls commented Sep 13, 2016

Coverage Status

Coverage remained the same at 86.659% when pulling 43a05bc on more_deprecated_attributes into 508c7ac on master.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Sep 13, 2016

+1, thanks

@jdricklefs jdricklefs merged commit fb0981e into master Sep 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdricklefs jdricklefs deleted the more_deprecated_attributes branch Sep 13, 2016

bartosh pushed a commit to bartosh/zipline that referenced this pull request Sep 27, 2016

MAINT: Add additional fields to __getitem__ for Order (quantopian#1483)
These were previously available like the others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment