New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adds truncate method to BcolzMinuteBarWriter #1499

Merged
merged 3 commits into from Sep 19, 2016

Conversation

Projects
None yet
3 participants
@yankees714
Contributor

yankees714 commented Sep 19, 2016

Moved from internal code.

@ehebert

This looks good to me.
Small note about test method name, but not a blocking request.

@@ -943,3 +944,151 @@ def test_set_sid_attrs(self):
# Read the attributes
for k, v in attrs.items():
self.assertEqual(self.reader.get_sid_attr(sid, k), v)
def test_rollback_between_data_points(self):

This comment has been minimized.

@ehebert

ehebert Sep 19, 2016

Member

test_truncate to match the changed method name?

self.assertEqual(0.0, volume_price)
def test_rollback_all_data_points(self):

This comment has been minimized.

@ehebert

ehebert Sep 19, 2016

Member

Likewise test_truncate...

@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

2 similar comments
@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

2 similar comments
@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

@coveralls

This comment has been minimized.

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.03%) to 86.669% when pulling 4eb5f29 on bcolz-minute-reader-sids into 7de7067 on master.

@yankees714 yankees714 changed the title from ENH: Adds rollback method to BcolzMinuteBarWriter to ENH: Adds truncate method to BcolzMinuteBarWriter Sep 19, 2016

@yankees714 yankees714 merged commit 95e07f2 into master Sep 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yankees714 yankees714 deleted the bcolz-minute-reader-sids branch Sep 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment