MAINT: Remove future_chain API method.
#1502
Conversation
| 12: 'Z', # December | ||
| } | ||
| for key in codes: | ||
| self.assertEqual(codes[key], month_to_cme_code(key)) |
There was a problem hiding this comment.
Since we're not removing cme_code_to_month or month_to_cme_code, should we maybe relocate these two tests?
There was a problem hiding this comment.
Open to adding them back in. Had removed them because it was essentially testing whether a dict is behaving as expected. (And the unused functions may be an unnecessary step. Following the pattern in other places where we refer to definitions, the definitions could be used as CME_CODE_TO_MONTH[code] and MONTH_TO_CME_CODE[code].
There was a problem hiding this comment.
+1 on removing the functions.
| @@ -295,15 +295,6 @@ class SymbolNotFound(ZiplineError): | |||
| """.strip() | |||
|
|
|||
|
|
|||
| class RootSymbolNotFound(ZiplineError): | |||
There was a problem hiding this comment.
We'll probably still need something like this, right?
There was a problem hiding this comment.
Probably, can change patch so that it remains.
`future_chain` will be replaced by the as yet to be implemented method, `data.current_chain` Also removing `FutureChain` which will be replaced by another version which only supports indexing and iteration.
ehebert
force-pushed
the
remove-future-chain
branch
from
09f2759
to
f4daf10
Compare
future_chainwill be replaced by the as yet to be implemented method,data.current_chainAlso removing
FutureChainwhich will be replaced by another versionwhich only supports indexing and iteration.