New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Catch all missing data exceptions when computing dividend ratios #1507

Merged
merged 2 commits into from Sep 22, 2016

Conversation

Projects
None yet
3 participants
@yankees714
Contributor

yankees714 commented Sep 22, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Sep 22, 2016

Coverage Status

Coverage remained the same at 86.548% when pulling 2c90d0d on calc-dividend-ratios-handle-all-no-data into 9d7049a on master.

@ehebert

This comment has been minimized.

Member

ehebert commented Sep 22, 2016

This works, seems like there should be a common base for those exceptions though.
e.g. NoDataAfterDate could subclass NoDataOnDate.

@coveralls

This comment has been minimized.

coveralls commented Sep 22, 2016

Coverage Status

Coverage remained the same at 86.548% when pulling 4e45a4d on calc-dividend-ratios-handle-all-no-data into 9d7049a on master.

@yankees714 yankees714 merged commit ca5f98b into master Sep 22, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yankees714 yankees714 deleted the calc-dividend-ratios-handle-all-no-data branch Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment