New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix events loader blaze query #1538

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
3 participants
@llllllllll
Member

llllllllll commented Oct 13, 2016

fixes an issue in ffill_query_in_range when we didn't have checkpoints.

# Cut the dates in half so we need to forward fill some data which
# is not in our window. The results should be computed the same as if
# we had computed accross the entire window and then sliced after the

This comment has been minimized.

@ssanderson

ssanderson Oct 13, 2016

Member

typo: "accross"

@ssanderson

This comment has been minimized.

Member

ssanderson commented Oct 13, 2016

LGTM other than one typo.

@llllllllll llllllllll force-pushed the events-loader-query-fix branch from f8b2af5 to abcb627 Oct 13, 2016

@coveralls

This comment has been minimized.

coveralls commented Oct 13, 2016

Coverage Status

Coverage decreased (-0.04%) to 86.858% when pulling abcb627 on events-loader-query-fix into 48b43c0 on master.

@coveralls

This comment has been minimized.

coveralls commented Oct 13, 2016

Coverage Status

Coverage decreased (-0.04%) to 86.858% when pulling abcb627 on events-loader-query-fix into 48b43c0 on master.

@llllllllll llllllllll merged commit 4386895 into master Oct 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the events-loader-query-fix branch Oct 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment