New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: An improved error message when calling zipline api functions #1593

Merged
merged 1 commit into from Nov 11, 2016

Conversation

Projects
None yet
4 participants
@richafrank
Member

richafrank commented Nov 11, 2016

outside of a running simulation. Previously, an AttributeError was
raised.

The goal here is to make the situation clearer for developers, for example: #1541 and #448 (comment)

What do folks think of the message?

ENH: An improved error message when calling zipline api functions
outside of a running simulation. Previously, an AttributeError was
raised.
@ssanderson

This comment has been minimized.

Member

ssanderson commented Nov 11, 2016

👍 from me

@ssanderson

This comment has been minimized.

Member

ssanderson commented Nov 11, 2016

The only change I could maybe see here is adding a specific exception type for this (e.g. NoSimulationRunning) rather than RuntimeError. But I don't feel super strongly about it either way.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 11, 2016

+1 also, I think the runtime error is fine because I don't expect anyone to want to catch this

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 11, 2016

Ok, cool, then I'm going to merge on travis passing.

@coveralls

This comment has been minimized.

coveralls commented Nov 11, 2016

Coverage Status

Coverage decreased (-0.004%) to 86.992% when pulling 1d2d6d8 on nicer-message into 8b8b4a8 on master.

@richafrank richafrank merged commit 54487ef into master Nov 11, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richafrank richafrank deleted the nicer-message branch Nov 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment