New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow custom chunks iterators for attach_pipeline #1617

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
3 participants
@llllllllll
Member

llllllllll commented Dec 16, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Dec 16, 2016

Coverage Status

Coverage increased (+0.002%) to 87.141% when pulling 76758e9 on chunks-iter into 7af53dd on master.

@richafrank

LGTM. I had a couple suggestions.

self._pipelines[name] = pipeline, chunks
chunks = chain([5], repeat(126))
elif isinstance(chunks, int):
chunks = repeat(int(chunks))

This comment has been minimized.

@richafrank

richafrank Dec 16, 2016

Member

I suppose we don't need to call int on chunks here anymore.

while remaining > 0:
chunk = st.randint(3)
chunks.append(chunk)
remaining -= chunk

This comment has been minimized.

@richafrank

richafrank Dec 16, 2016

Member

Subjective, but I think chunks = [st.randint(3) for _ in range(remaining)] might be clearer.

This comment has been minimized.

@llllllllll

llllllllll Dec 16, 2016

Member

Talked IRL, this is slightly different. We are subtracting the random chunksize from remaining in each iteration.

@llllllllll llllllllll force-pushed the chunks-iter branch from 76758e9 to b784a4c Dec 16, 2016

@coveralls

This comment has been minimized.

coveralls commented Dec 16, 2016

Coverage Status

Coverage increased (+0.002%) to 87.141% when pulling b784a4c on chunks-iter into 7af53dd on master.

@llllllllll llllllllll merged commit a542308 into master Dec 16, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the chunks-iter branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment