Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adds StaticSids pipeline filter #1717

Merged
merged 1 commit into from Mar 22, 2017
Merged

ENH: Adds StaticSids pipeline filter #1717

merged 1 commit into from Mar 22, 2017

Conversation

@yankees714
Copy link
Contributor

@yankees714 yankees714 commented Mar 22, 2017

Useful for avoiding the need to create Asset objects when sids are easier to use.

This is based off the existing implementation of StaticAssets, and StaticAssets is now implemented as a wrapper around StaticSids.

Andrew Daniels
Useful for avoiding the need to create Asset objects when sids are
easier to use.

This is based off the existing implementation of StaticAssets, and
StaticAssets is now implemented as a wrapper around StaticSids.
@yankees714 yankees714 requested a review from ssanderson Mar 22, 2017
@coveralls
Copy link

@coveralls coveralls commented Mar 22, 2017

Coverage Status

Coverage decreased (-0.05%) to 87.429% when pulling 7ff7c93 on static-sids-filter into 5fd20e1 on master.

Copy link
Contributor

@ssanderson ssanderson left a comment

👍 LGTM

@yankees714 yankees714 merged commit 43d6004 into master Mar 22, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yankees714 yankees714 deleted the static-sids-filter branch Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.