Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContinuousFuture to lookup_generic #1718

Merged
merged 1 commit into from Mar 25, 2017
Merged

Add ContinuousFuture to lookup_generic #1718

merged 1 commit into from Mar 25, 2017

Conversation

@dmichalowicz
Copy link
Contributor

@dmichalowicz dmichalowicz commented Mar 22, 2017

No description provided.

@dmichalowicz dmichalowicz requested a review from ehebert Mar 22, 2017
@dmichalowicz dmichalowicz force-pushed the more-generic branch from 4894b3d to 9afb30d Mar 23, 2017
Copy link
Contributor

@ehebert ehebert left a comment

We should add a test covering the ContinuousFuture being passed to lookup_generic.

# If the input is a ContinuousFuture just return it as-is.
if isinstance(asset_convertible_or_iterable, ContinuousFuture):
return asset_convertible_or_iterable

This comment has been minimized.

@ehebert

ehebert Mar 23, 2017
Contributor

This could also be part of the check that follows with an elif.
(Being an AssetConvertible is probably the most common case, so would want to check for that first.)

@coveralls
Copy link

@coveralls coveralls commented Mar 23, 2017

Coverage Status

Coverage increased (+0.003%) to 87.432% when pulling 821516a on more-generic into 43d6004 on master.

@dmichalowicz
Copy link
Contributor Author

@dmichalowicz dmichalowicz commented Mar 23, 2017

@ehebert Updated with a test.

@dmichalowicz dmichalowicz force-pushed the more-generic branch from 821516a to c86798b Mar 25, 2017
@coveralls
Copy link

@coveralls coveralls commented Mar 25, 2017

Coverage Status

Coverage increased (+0.003%) to 87.432% when pulling c86798b on more-generic into 43d6004 on master.

@dmichalowicz dmichalowicz merged commit 15b8832 into master Mar 25, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmichalowicz dmichalowicz deleted the more-generic branch Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.