New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make continuous future adjustment style an argument #1726

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@dmichalowicz
Contributor

dmichalowicz commented Mar 27, 2017

Allow specifying an adjustment style as a parameter, e.g. continuous_future('CL', offset=0, roll='volume', adjustment='add') is equivalent to continuous_future('CL', offset=0, roll='volume').adj('add')

@coveralls

This comment has been minimized.

coveralls commented Mar 27, 2017

Coverage Status

Coverage increased (+0.0009%) to 87.486% when pulling 361bdaf on cf-adjustment-arg into 759fc5b on master.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage decreased (-0.0008%) to 87.484% when pulling ddb58cc on cf-adjustment-arg into 759fc5b on master.

@ehebert

This comment has been minimized.

Member

ehebert commented Mar 29, 2017

To confirm, the intent is not just to make an equivalent API to .adj, but to replace it in favor of passing the adjustment arg.

If so, I agree with the API change and the implementation.
(The setting up of adjustment_children was awkward.)

@abhijeetkalyan abhijeetkalyan requested review from freddiev4 and removed request for freddiev4 Mar 29, 2017

@abhijeetkalyan

This comment has been minimized.

Member

abhijeetkalyan commented Mar 29, 2017

Sorry about the review request, misclick

@dmichalowicz

This comment has been minimized.

Contributor

dmichalowicz commented Mar 29, 2017

To confirm, the intent is not just to make an equivalent API to .adj, but to replace it in favor of passing the adjustment arg.

Yes, that's correct. Thanks for the review Eddie.

@dmichalowicz dmichalowicz force-pushed the cf-adjustment-arg branch from ddb58cc to 7829541 Mar 29, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 29, 2017

Coverage Status

Coverage decreased (-0.06%) to 87.43% when pulling 7829541 on cf-adjustment-arg into eb6d082 on master.

@dmichalowicz dmichalowicz merged commit 164838c into master Mar 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dmichalowicz dmichalowicz deleted the cf-adjustment-arg branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment