New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Show exchange as required for equities #1731

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@freddiev4
Contributor

freddiev4 commented Mar 30, 2017

Should fix #1626 after merging & then deploying docs

@freddiev4 freddiev4 requested a review from richafrank Mar 30, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 30, 2017

Coverage Status

Coverage decreased (-0.05%) to 87.43% when pulling 3225b8b on update-assetdbwriter-docs into 164838c on master.

@coveralls

This comment has been minimized.

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 87.484% when pulling 3225b8b on update-assetdbwriter-docs into 164838c on master.

@@ -388,7 +388,7 @@ def write(self,
The first date we have trade data for this asset.
auto_close_date : datetime, optional
The date on which to close any positions in this asset.
exchange : str, optional
exchange : str

This comment has been minimized.

@richafrank

richafrank Mar 30, 2017

Member

Looks good . Should we make the same change for futures below?

This comment has been minimized.

@freddiev4

freddiev4 Mar 30, 2017

Contributor

Sure. Just fixed that.

@coveralls

This comment has been minimized.

coveralls commented Mar 30, 2017

Coverage Status

Coverage decreased (-0.02%) to 87.464% when pulling 4f3950d on update-assetdbwriter-docs into 164838c on master.

@richafrank

This comment has been minimized.

Member

richafrank commented Apr 4, 2017

Looks good to me! Thanks @freddiev4 .

@freddiev4 freddiev4 force-pushed the update-assetdbwriter-docs branch 3 times, most recently from 20ab289 to 9884bc0 Apr 4, 2017

@coveralls

This comment has been minimized.

coveralls commented Apr 4, 2017

Coverage Status

Coverage remained the same at 87.464% when pulling 9884bc0 on update-assetdbwriter-docs into a006b4b on master.

@freddiev4 freddiev4 force-pushed the update-assetdbwriter-docs branch 2 times, most recently from fb057f2 to 0f36236 Apr 4, 2017

@freddiev4 freddiev4 force-pushed the update-assetdbwriter-docs branch from 0f36236 to 0c246a7 Apr 4, 2017

@coveralls

This comment has been minimized.

coveralls commented Apr 4, 2017

Coverage Status

Coverage remained the same at 87.464% when pulling 0c246a7 on update-assetdbwriter-docs into a006b4b on master.

@coveralls

This comment has been minimized.

coveralls commented Apr 4, 2017

Coverage Status

Coverage remained the same at 87.464% when pulling 0c246a7 on update-assetdbwriter-docs into a006b4b on master.

@freddiev4 freddiev4 merged commit 0746fc7 into master Apr 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freddiev4 freddiev4 deleted the update-assetdbwriter-docs branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment