Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Assets everywhere ... and a futures fix. #1757
The original point of this branch was to fix a bug in how we calculate a position's cost basis for futures (it wasn't taking into account contract size).
This led me into a refactoring that I had been meaning to do for a while, in which all mentions of
@jbredeche finished a pass here. Generally
There are a couple places where we're doing things like
asset = finder.retrieve_asset(asset), which are either redundant or pretty confusing. If they're redundant, then I think we can drop most of the code around managing multiplier caches in the position/performance tracking code, (which I think means we can drop the asset finder as well).