New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Swap conda build args to check CI label/channel first #1813

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
3 participants
@freddiev4
Contributor

freddiev4 commented May 24, 2017

Making this change because the build failed when we started building Python 3.5 packages for the first time; we were checking the Quantopian channel main label first to see if there is an existing built package for packages like sortedcontainers or setuptools_scm.

Order matters when passing -c flags to conda build.

We've also been unnecessarily building packages in our CI builds because the URL we specified in make_conda_packages.py needed to be updated to just be the name of the channel and label.

@coveralls

This comment has been minimized.

coveralls commented May 24, 2017

Coverage Status

Coverage remained the same at 87.586% when pulling 2b252dc on swap-make-conda-args into d760a84 on master.

BLD: Swap conda build args to check CI label/channel first
BLD: Change url to just channel/label path

@freddiev4 freddiev4 force-pushed the swap-make-conda-args branch from 2b252dc to 51b0313 May 24, 2017

@coveralls

This comment has been minimized.

coveralls commented May 24, 2017

Coverage Status

Coverage remained the same at 87.586% when pulling 51b0313 on swap-make-conda-args into d760a84 on master.

@freddiev4

This comment has been minimized.

Contributor

freddiev4 commented May 24, 2017

Talked IRL with @richafrank; merging

@freddiev4 freddiev4 merged commit a5ec24e into master May 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freddiev4 freddiev4 deleted the swap-make-conda-args branch May 24, 2017

@richafrank

This comment has been minimized.

Member

richafrank commented May 24, 2017

@freddiev4 Assuming this fixed it, will you make the same change to our Travis config?

@freddiev4

This comment has been minimized.

Contributor

freddiev4 commented May 25, 2017

@richafrank Sure! x-ref #1814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment