New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean docs #1943

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@richafrank
Member

richafrank commented Sep 12, 2017

For #1941

@freddiev4 Will you confirm that running deploy.py from this branch removes the yahoo bundle html for you? Since this is about stale files, I want to make sure I didn't pollute my test env.

@richafrank richafrank requested a review from freddiev4 Sep 12, 2017

@richafrank richafrank force-pushed the clean-docs branch from a9e0848 to 9f9bbb9 Sep 12, 2017

@coveralls

This comment has been minimized.

coveralls commented Sep 12, 2017

Coverage Status

Changes Unknown when pulling a9e0848 on clean-docs into ** on master**.

@coveralls

This comment has been minimized.

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 87.19% when pulling 9f9bbb9 on clean-docs into 2caf5b8 on master.

@ernestoeperez88

This comment has been minimized.

Member

ernestoeperez88 commented Sep 13, 2017

I tested this as well. I generated old docs using 1.1.0, and then generated new ones using this branch. The yahoo html file gets removed from the new docs.

@richafrank

This comment has been minimized.

Member

richafrank commented Sep 13, 2017

Thanks @ernestoeperez88 !

@richafrank richafrank merged commit 77922dd into master Sep 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richafrank richafrank deleted the clean-docs branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment