New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: networkx 2 changes the behavior of out_degree #1996

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@richafrank
Member

richafrank commented Oct 26, 2017

For #1995

@richafrank richafrank requested a review from ssanderson Oct 26, 2017

@ssanderson

This comment has been minimized.

Member

ssanderson commented Oct 26, 2017

This looks like the right change for now. I tried just updating the zipline logic that interacts with networkx (which is pretty minimal), but it looks like there's some upstream breakage in odo with the latest networkx as well, so 👍 .

@ssanderson

This comment has been minimized.

Member

ssanderson commented Oct 26, 2017

xref blaze/odo#579 for the odo breakage.

@richafrank

This comment has been minimized.

Member

richafrank commented Oct 26, 2017

Oh, thanks for looking - that's too bad re: odo.

@coveralls

This comment has been minimized.

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 87.222% when pulling 93e1aae on networkx-less-than-2 into 0770d3b on master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 87.222% when pulling 93e1aae on networkx-less-than-2 into 0770d3b on master.

@richafrank richafrank merged commit 61c8869 into master Oct 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richafrank richafrank deleted the networkx-less-than-2 branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment