New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove old Yahoo code #2032

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@freddiev4
Contributor

freddiev4 commented Nov 30, 2017

We don't use this code anywhere that I'm aware of (grepped through Zipline in emacs)

@freddiev4 freddiev4 force-pushed the remove-old-yahoo-code branch from 0038a47 to d3e86b0 Nov 30, 2017

@coveralls

This comment has been minimized.

coveralls commented Nov 30, 2017

Coverage Status

Coverage increased (+0.04%) to 87.411% when pulling d3e86b0 on remove-old-yahoo-code into 42b3200 on master.

:type adjusted: bool
"""
data = _load_raw_yahoo_data(indexes, stocks, start, end)

This comment has been minimized.

@prsutherland

prsutherland Nov 30, 2017

Member

You might be able to ax _load_raw_yahoo_data too.

This comment has been minimized.

@freddiev4

freddiev4 Dec 1, 2017

Contributor

Oooh good call

@coveralls

This comment has been minimized.

coveralls commented Nov 30, 2017

Coverage Status

Coverage increased (+0.04%) to 87.411% when pulling d3e86b0 on remove-old-yahoo-code into 42b3200 on master.

@freddiev4 freddiev4 force-pushed the remove-old-yahoo-code branch from d3e86b0 to e3c3ef1 Dec 1, 2017

@freddiev4 freddiev4 force-pushed the remove-old-yahoo-code branch from e3c3ef1 to ce29cf5 Dec 1, 2017

@coveralls

This comment has been minimized.

coveralls commented Dec 1, 2017

Coverage Status

Coverage increased (+0.2%) to 87.537% when pulling ce29cf5 on remove-old-yahoo-code into 42b3200 on master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Dec 1, 2017

Coverage Status

Coverage increased (+0.2%) to 87.537% when pulling ce29cf5 on remove-old-yahoo-code into 42b3200 on master.

@freddiev4 freddiev4 requested a review from prsutherland Dec 1, 2017

@prsutherland

Sorry for the delay, this one slipped through the cracks!

@freddiev4 freddiev4 merged commit fedf591 into master Dec 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freddiev4 freddiev4 deleted the remove-old-yahoo-code branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment