Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollingPanel fix when adding/dropping new fields #349

Closed
wants to merge 5 commits into from
Closed

Conversation

@twiecki
Copy link
Contributor

@twiecki twiecki commented Jun 11, 2014

Fixes bugs that occur when RollingPanel is supposed to drop old or add new symbols. Uses pd.concat() which gives a 5x speed-up over .update().

Supersedes #346.

@@ -0,0 +1,167 @@
#
# Copyright 2013 Quantopian, Inc.

This comment has been minimized.

@ehebert

ehebert Jun 13, 2014
Contributor

2014

twiecki added 4 commits Jun 4, 2014
There quite some bugs in certain corner cases. Dropping of obsolete
axes was not working correctly, roll over could cause obsolete axes
to not drop. The tests are much more stringent now as well.

Also speeds up prior behavior up 10x due to concatenating Panels
instead of .update()ing them.
Under the hood, .update() loops elementwise through the whole 3D array
which is obviously very inefficient. Instead, we can just concat() the
arrays we need which uses more efficient block-wise memory copying.
@twiecki
Copy link
Contributor Author

@twiecki twiecki commented Jun 14, 2014

Closing in favor of bug-fix only changes with 96bdb22.

pd.concat() has ordering problems.

@twiecki twiecki closed this Jun 14, 2014
@freddiev4 freddiev4 deleted the rolling_panel_fix branch Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.