New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand get_environment #449

Merged
merged 2 commits into from Dec 12, 2014

Conversation

Projects
None yet
4 participants
@fawce
Member

fawce commented Dec 9, 2014

No description provided.

@llllllllll

This comment has been minimized.

Member

llllllllll commented on zipline/algorithm.py in 0411627 Dec 8, 2014

should we rename self._environment to self._platform since it is no longer the environment?

This comment has been minimized.

Contributor

twiecki replied Dec 8, 2014

+1

This comment has been minimized.

Member

ssanderson replied Dec 8, 2014

I think the point of this is that environment now refers to a larger scope of values, and platform now refers to "where is my code running". I would prefer leaving this as is.

This comment has been minimized.

Contributor

twiecki replied Dec 8, 2014

Agreed. I understood @llllllllll's comment to suggest that this should be reflected in the internal variable name we use in TradingAlgorithm as well.

This comment has been minimized.

Member

fawce replied Dec 8, 2014

Yes, I plan to change it.

This comment has been minimized.

Member

ssanderson replied Dec 8, 2014

Ah. Yeah, I'm +1 on changing the internal variable name.

fawce added a commit that referenced this pull request Dec 12, 2014

Merge pull request #449 from quantopian/bug_5089
expand get_environment

@fawce fawce merged commit cd976ee into master Dec 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@twiecki twiecki deleted the bug_5089 branch Dec 13, 2014

@twiecki

This comment has been minimized.

Contributor

twiecki commented Dec 13, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment