New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Don't pin install requirements to exact versions #825

Merged
merged 4 commits into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@richafrank
Member

richafrank commented Nov 10, 2015

Instead, use those versions as lower bounds, so zipline
will work with packages that require other versions.

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

@llllllllll How does this look as a fix for #823 ?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 10, 2015

This looks good, but it looks like our travis file will be pulling the newest versions of everything (like flake8 ^^).

Maybe we could do an extras_requires like strict so people can pip install zipline[strict] which will force the versions to what we want tested. We can then use this for travis

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

pip install zipline[strict] makes sense to me.

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

I think we should call read_requirements('etc/requirements_dev.txt', convert_eq_to_lte=False), since dev requirements should always be pegged, and I imagine that will solve this issue without [strict]. Do you think [strict] would be otherwise helpful?

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

Ah, would be nice to pin them for travis...

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

@llllllllll I can't seem to override the install_requires with 'strict' in the extras_require. Any suggestions?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 10, 2015

Can you not just make the extras_requires list for strict the more strict version and then those will be downgraded when you use that target?

@richafrank

This comment has been minimized.

Member

richafrank commented Nov 10, 2015

That's what I had hoped, but based on the travis build log, seems like not.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 10, 2015

hmm, let's play with this a bit. I think that we want this to be easy since we will want to do this on travis. I wonder if there is any existing work for this.

richafrank added some commits Nov 10, 2015

BLD: Don't pin install requirements to exact versions
Instead, use those versions as lower bounds, so zipline
will work with packages that require other versions.
BLD: Use strict bounds install for travis
with explicit requirements files

Need to build extension modules explicitly now that we're not
installing zipline

Adds support for upper bounds, since we thought newer bcolz didn't
work.  It just needed newer setuptools.

@richafrank richafrank force-pushed the reqs_as_minimums branch from d617b6f to f3b701f Nov 10, 2015

@@ -43,7 +43,7 @@ None
Build
~~~~~
None
Make zipline install requirements more flexible (:issue:`825`).

This comment has been minimized.

@llllllllll

llllllllll Nov 10, 2015

Member

Can you put a * so this appears as a bulleted list?

👍 for the entry

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 10, 2015

one comment on the whatsnew, then :shipit:

@richafrank richafrank force-pushed the reqs_as_minimums branch from f3b701f to 234ab15 Nov 11, 2015

richafrank added a commit that referenced this pull request Nov 11, 2015

Merge pull request #825 from quantopian/reqs_as_minimums
BLD: Don't pin install requirements to exact versions

@richafrank richafrank merged commit ff1bd4b into master Nov 11, 2015

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richafrank richafrank deleted the reqs_as_minimums branch Nov 11, 2015

@ssanderson ssanderson referenced this pull request Nov 18, 2015

Closed

Versions #857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment