New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive conveniences #836

Merged
merged 10 commits into from Nov 21, 2015

Conversation

Projects
None yet
2 participants
@ssanderson
Member

ssanderson commented Nov 12, 2015

No description provided.

@ssanderson ssanderson force-pushed the interactive-conveniences branch 3 times, most recently from 3bf0b00 to 2d69f3e Nov 17, 2015

@ssanderson ssanderson force-pushed the interactive-conveniences branch from 2d69f3e to f1d33ae Nov 21, 2015

self.window_length,
self.anchor,
self.max_anchor,
def inspect(self):

This comment has been minimized.

@llllllllll

llllllllll Nov 21, 2015

Member

why is this not the repr? Same above

This comment has been minimized.

@ssanderson

ssanderson Nov 21, 2015

Member

I had it as the repr originally, but that's really annoying if you have a list of these or something. Too much text I think.

Path to pass to `AssetFinder`.
calendar : pd.DatetimeIndex
Calendar to use for the loader.
warmup_assets : bool

This comment has been minimized.

@llllllllll

llllllllll Nov 21, 2015

Member

bool, optional

"""
loader = USEquityPricingLoader.from_files(daily_bar_path, adjustments_path)
if not asset_db_path.startswith("sqlite:"):

This comment has been minimized.

@llllllllll

llllllllll Nov 21, 2015

Member

does it need to be sqlite? the backend supports any sqldb no?

This comment has been minimized.

@ssanderson

ssanderson Nov 21, 2015

Member

Maybe this is better as:

if os.path.isfile(asset_db_path):?

Parameters
----------
format : str, optional

This comment has been minimized.

@llllllllll

llllllllll Nov 21, 2015

Member

{'svg', 'png', 'jpeg'}

@@ -145,3 +145,20 @@ def to_graph(self, screen_name, default_screen):
columns[screen_name] = screen
return TermGraph(columns)
def show_graph(self, format='svg'):

This comment has been minimized.

@llllllllll

llllllllll Nov 21, 2015

Member

maybe expect_value to check that I don't pass format='ayy'

This comment has been minimized.

@ssanderson

ssanderson Nov 21, 2015

Member

I added an explicit elif and a default branch that raises.

This comment has been minimized.

@llllllllll
@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 21, 2015

Other than the comments looks good.

ssanderson added a commit that referenced this pull request Nov 21, 2015

@ssanderson ssanderson merged commit 13c9610 into master Nov 21, 2015

3 checks passed

Scrutinizer Analysis 9 updated code elements
Details
Scrutinizer Tests Tests are not configured
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssanderson ssanderson deleted the interactive-conveniences branch Nov 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment