Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Limit the timer report to just the 15 longest tests #838

Merged
merged 2 commits into from Nov 13, 2015
Merged

Conversation

@richafrank
Copy link
Member

@richafrank richafrank commented Nov 13, 2015

The default of all the tests is pretty spammy.

richafrank added 2 commits Nov 12, 2015
The default of all the tests is pretty spammy.
@richafrank richafrank force-pushed the limit_timer branch from 224ceba to f3f5d8a Nov 13, 2015
richafrank added a commit that referenced this pull request Nov 13, 2015
TST: Limit the timer report to just the 15 longest tests
@richafrank richafrank merged commit 7f38f90 into master Nov 13, 2015
2 checks passed
2 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richafrank richafrank deleted the limit_timer branch Nov 13, 2015
@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Nov 13, 2015

@llllllllll @richafrank I added this change directly to setup.cfg in my speedup-retrieve-all branch so that it also becomes the default for devs.

@llllllllll
Copy link
Contributor

@llllllllll llllllllll commented Nov 13, 2015

Looks like you have timer-filter=warning. Also, this is added to the setup.cfg here too

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Nov 13, 2015

Oh, actually, I made a slightly different change in my branch: I made it only show tests that were in the warning threshold for speed. Anythoughts on the difference?

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Nov 13, 2015

@llllllllll yeah, I thought I had done top-n, but I actually did the threshold. Any preference between the two? I'm rebasing a conflict here now.

@richafrank
Copy link
Member Author

@richafrank richafrank commented Nov 13, 2015

How much output do we get with just warning?

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Nov 13, 2015

@richafrank running now to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.