New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember downloads #841

Merged
merged 3 commits into from Nov 13, 2015

Conversation

Projects
None yet
2 participants
@ssanderson
Member

ssanderson commented Nov 13, 2015

No description provided.

@ssanderson

This comment has been minimized.

Member

ssanderson commented Nov 13, 2015

Partial fix for #839.

I wanted to try this out now while the Fed is still delayed.

ssanderson added some commits Nov 13, 2015

MAINT: Add __future__ print function import.
We do print(stock) in this file, which happens to work in py2, but is
confusing.
ENH: Check `getmtime` on download locations.
Rather than repeatedly try and fail to download data that's not yet
available, only try to download again if we haven't successfully
downloaded in the last hour.

@ssanderson ssanderson force-pushed the remember-downloads branch from 11dce96 to 43ac9ea Nov 13, 2015

@@ -12,6 +12,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from __future__ import print_function

This comment has been minimized.

@llllllllll

llllllllll Nov 13, 2015

Member

are we using print somewhere?

This comment has been minimized.

@ssanderson

ssanderson Nov 13, 2015

Member

https://github.com/quantopian/zipline/pull/841/files#diff-0ec9e6870d90568b4a83e0daa3a317b1L290

This happened to work because print(stock) is still valid in Py2. But from git blame it's clear that the intention was for that to be using the print function, which I suspect was either accidentally omitted or removed at a later point.

This comment has been minimized.

@llllllllll

llllllllll Nov 13, 2015

Member

kk, just wanted to make sure it was still needed

@ssanderson

This comment has been minimized.

Member

ssanderson commented Nov 13, 2015

@llllllllll good to merge?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Nov 13, 2015

yes

ssanderson added a commit that referenced this pull request Nov 13, 2015

@ssanderson ssanderson merged commit abbda17 into master Nov 13, 2015

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssanderson ssanderson deleted the remember-downloads branch Nov 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment