Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix error messages for set_(commission|slippage) #923

Merged
merged 1 commit into from Dec 22, 2015

Conversation

@llllllllll
Copy link
Contributor

@llllllllll llllllllll commented Dec 18, 2015

These called the functions 'update_(commission|slippage) leading to
confusing messages when you called them post init.

These called the functions 'update_(commission|slippage) leading to
confusing messages when you called them post init.
@richafrank
Copy link
Member

@richafrank richafrank commented Dec 18, 2015

Thanks for the cleanup @llllllllll . Makes sense to me.

llllllllll added a commit that referenced this pull request Dec 22, 2015
MAINT: fix error messages for set_(commission|slippage)
@llllllllll llllllllll merged commit 825f7b3 into master Dec 22, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@llllllllll llllllllll deleted the rename-error-cases branch Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.