New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda source build #937

Merged
merged 6 commits into from Jan 15, 2016

Conversation

Projects
None yet
4 participants
@richafrank
Member

richafrank commented Dec 31, 2015

Allows us to build conda packages for the latest zipline and its dependencies. Builds from local source instead of pypi, pulling in requirements from our requirements.txt.

Requires this change to conda-build: conda/conda-build#717

@ssanderson

This comment has been minimized.

Member

ssanderson commented Dec 31, 2015

@richafrank are we blocked on being able to push conda packages until conda/conda-build#717 is merged?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jan 2, 2016

I don't thinl this would block uploading packages, we can always build them locally with our patch applied and then upload to anaconda.org.

@llllllllll llllllllll added the Build label Jan 2, 2016

@@ -214,6 +228,7 @@ def pre_setup():

pre_setup()

conda_build = os.path.basename(sys.argv[0]) == 'conda-build'

This comment has been minimized.

@llllllllll

llllllllll Jan 2, 2016

Member

Do you think we should PR a feature that adds a CONDA_BUILD variable to the name space when running? This will not be true if you symlink conda build or run it from a location not in your path like ./conda-build

This comment has been minimized.

@richafrank

richafrank Jan 4, 2016

Member

Sounds like a good idea to me.

@richafrank

This comment has been minimized.

Member

richafrank commented Jan 5, 2016

Note: need to add whatsnew


requirements:
build:
- python
- setuptools
- cython
- cython ==0.22.1
- numpy ==1.9.2

This comment has been minimized.

@twiecki

twiecki Jan 5, 2016

Contributor

Does it only work with these specific versions?

This comment has been minimized.

@richafrank

richafrank Jan 6, 2016

Member

With numpy>=1.10 I'm getting ValueError: numpy.dtype has the wrong size, try recompiling. I think @llllllllll was getting this too.

numpy also included in the run requirements, so I'll remove this pinned version, but add the cap at 1.9 for now. I'll also give us back non-strict versions on the other run requirements - that was unintentional.

@twiecki

This comment has been minimized.

Contributor

twiecki commented Jan 6, 2016

I think it'd be worth investigating why we can't build for numpy 1.10. I'm afraid a conda build for numpy 1.9 won't be terribly useful to most users as most of anaconda is built against 1.10.

@twiecki

This comment has been minimized.

Contributor

twiecki commented Jan 6, 2016

Here's an example: quantopian/pyfolio#73 (comment)

@richafrank

This comment has been minimized.

Member

richafrank commented Jan 6, 2016

I think it'd be worth investigating why we can't build for numpy 1.10. I'm afraid a conda build for numpy 1.9 won't be terribly useful to most users as most of anaconda is built against 1.10.

Agreed - will keep looking...

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jan 8, 2016

We can't upgrade numpy yet because #894 (comment) is still pending. This issue hasn't been fixed upstream in numpy yet so we are currently locked onto 1.9.2.

@richafrank

This comment has been minimized.

Member

richafrank commented Jan 15, 2016

Merging, though the conda-build branch has not yet been merged. Plan is to build from the branch until then.

richafrank added a commit that referenced this pull request Jan 15, 2016

@richafrank richafrank merged commit 0dac2e0 into master Jan 15, 2016

2 checks passed

Scrutinizer 11 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richafrank richafrank deleted the conda_source_build branch Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment