New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Account object's total_position_value is incorrect #950

Merged
merged 3 commits into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@jfkirk
Contributor

jfkirk commented Jan 14, 2016

Mea culpa. There was a typo that incorrectly assigned the 'total_positions_exposure' value to the 'total_positions_value' field.

This PR fixes that bug and adds tests to prevent a regression.

@jfkirk

This comment has been minimized.

Contributor

jfkirk commented Jan 15, 2016

@llllllllll Any idea why Travis tests failed? They seem unrelated to the changes.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jan 15, 2016

I was building conda packages yesterday in preparation for shipping 0.8.4. It appears the talib package that I built was using a different version of numpy. I will work on this.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jan 16, 2016

Builds are passing now

@@ -457,7 +457,7 @@ def as_account(self):
self.ending_cash + self.ending_value)
account.total_positions_value = \
getattr(self, 'total_positions_value', self.ending_value)
account.total_positions_value = \
account.total_positions_exposure = \

This comment has been minimized.

@jfkirk

jfkirk Jan 19, 2016

Contributor

This one line is the only functional change

@jfkirk jfkirk force-pushed the account-value-bug branch from 69712f4 to 85099c3 Jan 19, 2016

jfkirk added a commit that referenced this pull request Jan 20, 2016

Merge pull request #950 from quantopian/account-value-bug
BUG: Account object's total_position_value is incorrect

@jfkirk jfkirk merged commit b16e2a7 into master Jan 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jfkirk jfkirk deleted the account-value-bug branch Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment