New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add right-binding operators to NumExprFilter. #991

Merged
merged 3 commits into from Feb 11, 2016

Conversation

Projects
None yet
2 participants
@ssanderson
Member

ssanderson commented Feb 10, 2016

Fixes a bug where doing a boolean comparison between a non-numexpr
Filter and a NumExprFilter would fail because we don't implement
__rand__ and __ror__.

ssanderson added some commits Feb 10, 2016

BUG: Add right-binding operators to NumExprFilter.
Fixes a bug where doing a boolean comparison between a non-numexpr
Filter and a NumExprFilter would fail because we don't implement
`__rand__` and `__ror__`.
}
# Should be True on the diagonal.
eye_filter = f > g
eye_filter = (f > g)

This comment has been minimized.

@llllllllll

llllllllll Feb 10, 2016

Member

why the parens?

This comment has been minimized.

@ssanderson

ssanderson Feb 10, 2016

Member

I think it's slightly more readable.

This comment has been minimized.

@llllllllll

This comment has been minimized.

@ssanderson

ssanderson Feb 10, 2016

Member

It's easy to misread this as a chained comparison.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Feb 10, 2016

Test was really clear, thanks! lgtm

ssanderson added a commit that referenced this pull request Feb 11, 2016

Merge pull request #991 from quantopian/fix-right-binding-filter-ops
BUG: Add right-binding operators to NumExprFilter.

@ssanderson ssanderson merged commit b651993 into master Feb 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssanderson ssanderson deleted the fix-right-binding-filter-ops branch Feb 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment