Added auto PageContext switch on BeforeStep binding #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brrovko
reviewed
Nov 1, 2021
Brrovko
reviewed
Nov 1, 2021
src/Behavioral.Automation/Services/Mapping/ScopeContextManager.cs
Outdated
Show resolved
Hide resolved
Brrovko
reviewed
Nov 1, 2021
Brrovko
approved these changes
Nov 1, 2021
SergeyRuzin
approved these changes
Nov 1, 2021
|
|
||
| public void SwitchPage(string pageName) | ||
| { | ||
| var pageScopeContext = _uriToPageScopeMapper.GetPageScopeContext(pageName); |
Contributor
There was a problem hiding this comment.
Probably, call of SwitchPage method is not needed anymore from NavigationBindings.
Collaborator
Author
There was a problem hiding this comment.
Not sure, I think we still need that, in case if step is complex and we call driverService.Navigate() multiple times inside of it, Of course it may lead to extra context switches, but Andrey agreed that they are not that time consuming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.