Updated packages (including Selenium to 4 version) #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRuzin
requested review from
Brrovko,
Georgiy-Petrov-Quantori,
ILastovka and
vladimir-s-quantori
Brrovko
reviewed
Dec 1, 2021
| { | ||
| public class BrowserRunner | ||
| { | ||
| public RemoteWebDriver Driver; |
Contributor
There was a problem hiding this comment.
Why renamed? We can use not only ChromiumDriver.
Contributor
There was a problem hiding this comment.
Maybe, we can use an interface here
Contributor
Author
There was a problem hiding this comment.
Changed to IWebDriver since RemoteWebDriver cannot be cast into ChromeDriver
ILastovka
previously approved these changes
Dec 1, 2021
Brrovko
approved these changes
Dec 1, 2021
afomina-quantori
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.