Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hygine] constant define should be in global scope #57

Closed
Roger-luo opened this issue Jun 2, 2018 · 1 comment
Closed

[Hygine] constant define should be in global scope #57

Roger-luo opened this issue Jun 2, 2018 · 1 comment
Labels
bug Something isn't working
Milestone
v0.3

Comments

@Roger-luo
Copy link
Member

refactor ConstantGate.jl to a safer implementation with @eval macro. use gensym for constant bindings.
@Roger-luo Roger-luo added this to the v0.1.x milestone Jun 2, 2018
@Roger-luo Roger-luo added the bug Something isn't working label Jun 2, 2018
@Roger-luo
Copy link
Member Author

This problem is solved in v0.7. I fixed this with some ugly workaround. Remember to delete v0.6 workarounds when we drop v0.6 supports. Basically the behavior of @eval seems to be different in v0.7 and v0.6.

@Roger-luo Roger-luo modified the milestones: v0.1.x, v0.2 Jun 2, 2018
@Roger-luo Roger-luo mentioned this issue Aug 8, 2018
Closed
19 tasks
@Roger-luo Roger-luo modified the milestones: v0.2, v0.3 Aug 16, 2018
Roger-luo added a commit that referenced this issue Dec 7, 2021
@Roger-luo @GiggleLiu
allow complex parameter for TE (#58)
6feb56b 
* fix #57
Roger-luo pushed a commit that referenced this issue Dec 7, 2021
@github-actions
Format .jl files (#57)
10200d4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@Roger-luo