-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add parameters for PauliString and GlobalPhase #5089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(Note that contrary to what I said the linked issue, decompose doesn't work when parameterized anyway since it's not unitary, so we actually didn't need to change GlobalPhaseGate here. But I'd already done it before I noticed it was unnecessary, so I figured I may as well leave the change in place since it seems non-invasive and probably useful.) |
|
Fixed diagonalgate while I was here. Required changing |
|
@tanujkhattar do you mind taking this one? |
tanujkhattar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits.
This is great, Thanks!
tanujkhattar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for the changes!
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Misc check', 'Notebook formatting', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Type check', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
|
@tanujkhattar Can you kick cirqbot again? |
Allows parameters for coefficient of PauliString and GlobalPhase:
Also tests and fixes #4508 @tanujkhattar