Rename ActOnArgs to SimulationState #5288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
Collaborator
Author
|
@95-martin-orion Actually let's take the time to push #5283 independently and also bikeshed the names. I'll try to figure out what's up with the coverage in the meanwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of #5244. Will backfill the existing ActOnArgs classes in subsequent PR, as it will merge cleaner (here git detects the renamed file; if we do backfill here then git will see all new files). Will also need to rename a few methods like
_create_partial_act_on_argsin a future PR.This sits on top of #5283. We can either merge that one first, or just merge this at once.
@95-martin-orion Can we get through this fairly quickly before merge conflicts arise? (No HUGE rush, it only took about an hour and I can do it over from scratch in worst case). Feel free to bikeshed the new names. (I'm torn between
(OperationTarget, ActOnArgs) -> (SimulationState, DenseSimulationState)or-> (SimulationStateBase, SimulationState). (ActOnArgsContainer I renamed to SimulationProductState).