Readd old ActOnArgs, but deprecated #5296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
Collaborator
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
Eight near-identical 21-line files, looks good to me :)
Per discussion on the other PR, let's merge this into that one and that one into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@95-martin-orion Here's step 2, re-adds the deprecated old ActOnArgs. Your choice whether to merge this separately or all at once. It's only one commit beyond #5293. (fc5ddeb) It's only a couple minutes to cherry-pick again into a new PR if we end up doing something in #5293 that ends up causing merge conflicts here.