Skip to content

Conversation

@95-martin-orion
Copy link
Collaborator

Fixes #2570.

This is a breaking change, as placing noise before gates can have measurably distinct behavior from placing the same noise after gates (e.g. X(q), H(q) != H(q), X(q)). However, in the common use case where noise effects are small, this has minimal effect on the outcome of the circuit.

@95-martin-orion 95-martin-orion added the BREAKING CHANGE For pull requests that are important to mention in release notes. label May 3, 2022
@CirqBot CirqBot added the size: M 50< lines changed <250 label May 3, 2022
@95-martin-orion
Copy link
Collaborator Author

Placing noise before or after gates will be provided as an option instead of changing the default.

CirqBot pushed a commit that referenced this pull request May 31, 2022
Fixes #2570.

This is essentially a more friendly version of #5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Fixes quantumlib#2570.

This is essentially a more friendly version of quantumlib#5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Fixes quantumlib#2570.

This is essentially a more friendly version of quantumlib#5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE For pull requests that are important to mention in release notes. size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should ConstantQubitNoiseModel apply noise first rather than second?

2 participants