Change Pasqal to use transformers #5377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PasqalGateset that encapsulates gatesets used by the PasqalDevice classes. - Deprecate PasqalConverter and use cirq.convert_to_target_gateset instead.
dstrain115
requested review from
a team,
HGSilveri,
cduck and
vtomole
as code owners
HGSilveri
approved these changes
May 19, 2022
tanujkhattar
approved these changes
May 20, 2022
| gates (defaults to True). | ||
| """ | ||
|
|
||
| def __init__(self, include_controlled_ops: bool = True): |
Collaborator
There was a problem hiding this comment.
include_controlled_ops is slightly confusing, since we'll always have CZ as part of the gateset. Maybe change it to include_additional_controlled_ops ? It's hard to come up with better names here; do you have any other suggestions?
Collaborator
Author
There was a problem hiding this comment.
Done. I can't really come up with a good name either.
Comment on lines
101
to
102
| assert repr(gs) == 'cirq_pasqal.PasqalGateset(include_controlled_ops=True)' | ||
| assert repr(gs2) == 'cirq_pasqal.PasqalGateset(include_controlled_ops=False)' |
Collaborator
There was a problem hiding this comment.
Use cirq.testing.assert_equivalent_repr instead.
…irq-1 into pasqal_transformers
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Add PasqalGateset that encapsulates gatesets used by the PasqalDevice classes. - Deprecate PasqalConverter and use cirq.convert_to_target_gateset instead. Fixes: quantumlib#5130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used by the PasqalDevice classes.
instead.
Fixes: #5130