GateFamily: do not serialize gates_to_accept and gates_to_ignore when empty #5532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
Collaborator
|
What motivates this change? It's generally only necessary to omit empty field when trying to maintain backwards compatibility with old versions of a class - is that what's happening here? |
Collaborator
Author
|
That's right, similar to the situation in GridDevice. Updated the PR description to be more specific. |
95-martin-orion
approved these changes
Jun 16, 2022
Collaborator
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
Cool, this all checks out.
Collaborator
Author
|
CI failures look similar to precision issues here: https://github.com/quantumlib/Cirq/runs/6926154638?check_suite_focus=true |
verult
force-pushed
the
gatefamily-tag-serialization
branch
from
a0aafcf to
f25d6cb
Compare
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
… empty (quantumlib#5532) GateFamily has existed prior to the last release, while GateFamily tag support has not gone into a release yet. Removing empty lists in serialized JSON before the next release as recommended to ensure backward compatibility. @95-martin-orion
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
… empty (quantumlib#5532) GateFamily has existed prior to the last release, while GateFamily tag support has not gone into a release yet. Removing empty lists in serialized JSON before the next release as recommended to ensure backward compatibility. @95-martin-orion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GateFamily has existed prior to the last release, while GateFamily tag support has not gone into a release yet. Removing empty lists in serialized JSON before the next release as recommended to ensure backward compatibility.
@95-martin-orion