Even more link fixes for 404ing links #5587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustehirth
requested review from
a team,
ColemanCollins,
cduck,
dabacon,
gmauricio,
nakardo,
verult,
vtomole and
wcourtney
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pavoljuhas
approved these changes
Jun 24, 2022
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a slight tweak in 7197ea8.
Depends if we want to link to https://quantumai.google/reference/python/cirq_google/transformers or https://quantumai.google/reference/python/cirq/TRANSFORMER. The former doesn't really apply and the latter auto-links. There are no reference docs to the _directory_ of transformers at https://github.com/quantumlib/Cirq/tree/master/cirq-core/cirq/transformers.
`cirq.transformer` or `cirq.transformers` doesn't link to any api reference pages, because they don't exist for the transformers directory. All of the transformers are available at the top level, but the
Collaborator
Author
|
@pavoljuhas Thanks for the review, made some minor additional changes on top of it. PTAL |
augustehirth
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.