Skip to content

Conversation

@mhucka
Copy link
Contributor

@mhucka mhucka commented Nov 28, 2025

This renames the workflow file to be the same as used in our other repos, and makes minor updates to the workflow. Compared to previous versions, this also removes the debug parameter and the uploading of SARIF files because we have never used it anyway.

This is almost identical to the latest version used in the qsim
repository. It has a minor improvement in using an `ubuntu-slim` runner
for the summary-writing job and also respecting the `runner.debug`
variable.
@github-actions github-actions bot added the size: M 50< lines changed <250 label Nov 28, 2025
@mhucka mhucka marked this pull request as ready for review November 28, 2025 04:59
@mhucka mhucka requested review from a team and vtomole as code owners November 28, 2025 04:59
@mhucka mhucka requested a review from mpharrigan November 28, 2025 04:59
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (4d75b4b) to head (7281f94).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7776      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       98434    98434              
==========================================
- Hits        98014    98013       -1     
- Misses        420      421       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mhucka added a commit to mhucka/Cirq that referenced this pull request Nov 28, 2025
The changes are being done in another PR:
quantumlib#7776
@mhucka mhucka mentioned this pull request Nov 28, 2025
@mhucka mhucka requested a review from pavoljuhas December 1, 2025 17:15
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@mhucka mhucka added this pull request to the merge queue Dec 5, 2025
Merged via the queue into quantumlib:main with commit a764b67 Dec 5, 2025
37 checks passed
@mhucka mhucka deleted the mh-update-scorecard-scanner branch December 5, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants