From 3dd5869263c2449b7094b9ae8653172920628b9d Mon Sep 17 00:00:00 2001 From: mhucka Date: Fri, 24 Apr 2026 04:25:24 +0000 Subject: [PATCH 1/3] Increase the delay between PubChem retries The live API test still fails in CI. It ends up failing 4 times in a row: ``` test_geometry_from_pubchem_live_api failed on attempt 1! Retrying! ... test_geometry_from_pubchem_live_api failed on attempt 2! Retrying! ... test_geometry_from_pubchem_live_api failed on attempt 3! Retrying! ... test_geometry_from_pubchem_live_api failed after 4 attempts! ``` Let's increase the retry delay. --- src/openfermion/chem/pubchem_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openfermion/chem/pubchem_test.py b/src/openfermion/chem/pubchem_test.py index ca5f6f806..e87b2e479 100644 --- a/src/openfermion/chem/pubchem_test.py +++ b/src/openfermion/chem/pubchem_test.py @@ -149,7 +149,7 @@ def test_water_2d(self, monkeypatch): with pytest.raises(ValueError, match='Incorrect value for the argument structure'): _ = geometry_from_pubchem('water', structure='foo') - @pytest.mark.flaky(retries=3, delay=2, only_on=[pubchempy.ServerBusyError]) + @pytest.mark.flaky(retries=3, delay=30, only_on=[pubchempy.ServerBusyError]) def test_geometry_from_pubchem_live_api(self): water_geometry = geometry_from_pubchem('water') assert len(water_geometry) == 3 From c91abee8f8d6d768d10bd1213cfb5b92bac994fa Mon Sep 17 00:00:00 2001 From: Michael Hucka Date: Thu, 23 Apr 2026 21:28:49 -0700 Subject: [PATCH 2/3] Update src/openfermion/chem/pubchem_test.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- src/openfermion/chem/pubchem_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openfermion/chem/pubchem_test.py b/src/openfermion/chem/pubchem_test.py index e87b2e479..663cc4ed5 100644 --- a/src/openfermion/chem/pubchem_test.py +++ b/src/openfermion/chem/pubchem_test.py @@ -149,7 +149,7 @@ def test_water_2d(self, monkeypatch): with pytest.raises(ValueError, match='Incorrect value for the argument structure'): _ = geometry_from_pubchem('water', structure='foo') - @pytest.mark.flaky(retries=3, delay=30, only_on=[pubchempy.ServerBusyError]) + @pytest.mark.flaky(retries=3, delay=5, backoff=2, only_on=[pubchempy.ServerBusyError]) def test_geometry_from_pubchem_live_api(self): water_geometry = geometry_from_pubchem('water') assert len(water_geometry) == 3 From da51f408712d1418b0fed14a998903514aca4dea Mon Sep 17 00:00:00 2001 From: Michael Hucka Date: Thu, 23 Apr 2026 21:30:11 -0700 Subject: [PATCH 3/3] If using exponential back-off, let's use 10sec delay --- src/openfermion/chem/pubchem_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openfermion/chem/pubchem_test.py b/src/openfermion/chem/pubchem_test.py index 663cc4ed5..884f1be5f 100644 --- a/src/openfermion/chem/pubchem_test.py +++ b/src/openfermion/chem/pubchem_test.py @@ -149,7 +149,7 @@ def test_water_2d(self, monkeypatch): with pytest.raises(ValueError, match='Incorrect value for the argument structure'): _ = geometry_from_pubchem('water', structure='foo') - @pytest.mark.flaky(retries=3, delay=5, backoff=2, only_on=[pubchempy.ServerBusyError]) + @pytest.mark.flaky(retries=3, delay=10, backoff=2, only_on=[pubchempy.ServerBusyError]) def test_geometry_from_pubchem_live_api(self): water_geometry = geometry_from_pubchem('water') assert len(water_geometry) == 3