New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in travis config #297

Merged
merged 5 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@babbush
Contributor

babbush commented Mar 29, 2018

This should cause travis to fail until we've fixed the future dependency in setup. This should prevent such problems from occurring in the future. Once we've fixed the setup script we should merge this and then bump the version again (unfortunately).

@babbush babbush requested a review from jarrodmcc Mar 29, 2018

@jarrodmcc

This comment has been minimized.

Collaborator

jarrodmcc commented Mar 29, 2018

@googlebot

This comment has been minimized.

googlebot commented Mar 29, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@babbush

This comment has been minimized.

Contributor

babbush commented Mar 29, 2018

hmm, maybe this doesn't work.

@jarrodmcc

Seems to work, though we don't have the offending code present anymore

@babbush

This comment has been minimized.

Contributor

babbush commented Mar 29, 2018

What I did is that I removed the explicit install of the requirements and made travis actually install openfermion. But it was installing numpy/scipy/matplotlib twice and took longer to run. Hopefully this time around it is a little faster.

@babbush babbush merged commit 435c791 into quantumlib:master Mar 29, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 99.408%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment