New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added magnetic field to general hubbard model #475

Merged
merged 8 commits into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@bryano
Contributor

bryano commented Oct 2, 2018

No description provided.

@googlebot googlebot added the cla: yes label Oct 2, 2018

@bryano

This comment has been minimized.

Show comment
Hide comment
@bryano

bryano Oct 2, 2018

Contributor

Ready for review. Failing tests unrelated to this PR.

Contributor

bryano commented Oct 2, 2018

Ready for review. Failing tests unrelated to this PR.

@babbush

This comment has been minimized.

Show comment
Hide comment
@babbush

babbush Oct 2, 2018

Contributor

I restarted tests. The failing test is one I mention in #477 - its started to get kind of annoying.

Contributor

babbush commented Oct 2, 2018

I restarted tests. The failing test is one I mention in #477 - its started to get kind of annoying.

Bryan A. O'Gorman added some commits Oct 3, 2018

@bryano

This comment has been minimized.

Show comment
Hide comment
@bryano

bryano Oct 3, 2018

Contributor

Done

Contributor

bryano commented Oct 3, 2018

Done

@kevinsung

Please test this functionality in test_fermi_hubbard_square_special_general_equivalance.

Bryan A. O'Gorman added some commits Oct 4, 2018

Bryan A. O'Gorman
made magnetic field operator indexing-independent
added test for equivalence of magnetic field parameter in special and
general cases
Bryan A. O'Gorman
@bryano

This comment has been minimized.

Show comment
Hide comment
@bryano

bryano Oct 4, 2018

Contributor

Done

Contributor

bryano commented Oct 4, 2018

Done

@kevinsung

LGTM, just one function rename request.

@kevinsung kevinsung merged commit e64c17a into quantumlib:master Oct 5, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 99.635%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment