Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port packaging scripts from Cirq #486

Merged
merged 7 commits into from Nov 14, 2018

Conversation

Projects
None yet
4 participants
@kevinsung
Copy link
Collaborator

kevinsung commented Nov 14, 2018

Fixes #483

kevinsung added some commits Nov 14, 2018

@kevinsung kevinsung requested a review from Strilanc Nov 14, 2018

@googlebot googlebot added the cla: yes label Nov 14, 2018

@babbush

This comment has been minimized.

Copy link
Contributor

babbush commented Nov 14, 2018

Can you explain what this PR does?

@kevinsung

This comment has been minimized.

Copy link
Collaborator Author

kevinsung commented Nov 14, 2018

It adds scripts related to packaging and uploading to PyPI. For instance, you can cut a new release with a one-line command. You can also cut a dev release, or upload a release to the Test PyPI and verify that the release works as expected, which is good to do before doing a real release.

@Strilanc
Copy link
Contributor

Strilanc left a comment

LGTM after copyright notices fixes and mock removed from pytest requirements. Make sure you re-run the verify script after making that little edit, before submitting.

@@ -0,0 +1,112 @@
#!/usr/bin/env bash

# Copyright 2018 The Cirq Developers

This comment has been minimized.

Copy link
@Strilanc

Strilanc Nov 14, 2018

Contributor

Change this to the openfermion copyright notice.

@@ -0,0 +1,63 @@
#!/usr/bin/env bash

# Copyright 2018 The Cirq Developers

This comment has been minimized.

Copy link
@Strilanc

Strilanc Nov 14, 2018

Contributor

Change this to the openfermion copyright notice.

# Run tests.
echo Installing pytest requirements
if [ "${PYTHON_VERSION}" = "python2" ]; then
"${tmp_dir}/${PYTHON_VERSION}/bin/pip" install --quiet pytest mock

This comment has been minimized.

Copy link
@Strilanc

Strilanc Nov 14, 2018

Contributor

Are these requirements the same for openfermion as they are for cirq and openfermioncirq? You probably don't need mock.

Just unconditionally do "${tmp_dir}/${PYTHON_VERSION}/bin/pip" install --quiet pytest mock regardless of version

@kevinsung

This comment has been minimized.

Copy link
Collaborator Author

kevinsung commented Nov 14, 2018

@Strilanc I made the changes but staled your review

@kevinsung

This comment has been minimized.

Copy link
Collaborator Author

kevinsung commented Nov 14, 2018

... but I need this right now. Anyway, it's pretty clear that I just did what you said.

@kevinsung kevinsung merged commit 3359fee into quantumlib:master Nov 14, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 99.598%
Details

@kevinsung kevinsung deleted the kevinsung:packaging branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.