Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EQ_TOLERANCE from 1e-12 to 1e-8 #487

Merged
merged 3 commits into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@kevinsung
Copy link
Collaborator

commented Nov 14, 2018

Fixes #482 . 1e-8 is the default value for the atol parameter of numpy.allclose and similar functions.

Also adds back a debug line to a packaging script which I accidentally deleted.

@kevinsung kevinsung requested a review from babbush Nov 14, 2018

@googlebot googlebot added the cla: yes label Nov 14, 2018

kevinsung added some commits Nov 14, 2018

@babbush babbush merged commit 40ee750 into quantumlib:master Nov 14, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 99.592%
Details

@kevinsung kevinsung deleted the kevinsung:increase_eq_tol branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.