Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Define MajoranaOperator #501
referenced this pull request
Jan 10, 2019
ncrubin left a comment •
I'm curious why the choice for not extending
You might get some things for free if extending
I'll add a more detailed review and check for correctness shortly.
Yes, the main reason is that there is no action, so it's more natural to store the terms simply as tuples rather than tuples of tuples. It's possible that in the future it could become a subclass of SymbolicOperator, but in my opinion that requires some pretty fundamental changes to SymbolicOperator. In particular, I think the way to do that would be to define classes to represent the terms themselves and to implement term multiplication within those classes rather than in SymbolicOperator. However, that is a long-term and potentially controversial change.