Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of Project onto sector function. #538

Merged
merged 6 commits into from Sep 9, 2019

Conversation

@xabomon
Copy link
Contributor

commented Sep 6, 2019

Hi all,

After some discussion with the user @rugantio I decided to improve the existing functions project_onto_sector and projection_error.

The main enhancement consists on checking that the sectors are passed as 0 or 1 (which is clearly documented) instead of 1 or -1.
Additionally, I added some trivial assertions and update the test such that the assertions are tested.

Please, let me know if anything else is required.

PS: A previous PR didn't have the commits, sorry.

Best,
Xavi

@googlebot googlebot added the cla: yes label Sep 6, 2019

@ncrubin
ncrubin approved these changes Sep 9, 2019

@ncrubin ncrubin merged commit 3b2b15b into quantumlib:master Sep 9, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 99.64%
Details
@ncrubin

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Thanks @xabomon!

@xabomon xabomon deleted the xabomon:enh/projct_sector branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.